Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - mentioning angular-cli-ghpages addon #1070

Closed
wants to merge 1 commit into from
Closed

Update README.md - mentioning angular-cli-ghpages addon #1070

wants to merge 1 commit into from

Conversation

JohannesHoppe
Copy link
Contributor

@JohannesHoppe JohannesHoppe commented Jun 12, 2016

Say hello to angular-cli-ghpages!

We created an addon on top of tschaub/gh-pages.
Compared to github-pages:deploy it gives us much more flexibility where and how to push the builds to.
In our case this plugin is the base for some smoke tests against a build matrix.

Many thanks for considering! 😄

We created a similar addon on top of [tschaub/gh-pages](https://github.com/tschaub/gh-pages).
It gives us much more flexibility where and how to push the builds to.
In our case this plugin is the base for some smoke tests against a build matrix.

Many thanks for considering! :-)
@filipesilva
Copy link
Contributor

I can't merge this in, mostly because at the moment we're not really committed to the addon architecture.

But what I'd be happy to merge in is you adding this functionality to the existing one directly. If you want to try your hand at that, I'll ask you to keep all existing functionality and add tests for new one.

I did most of the code for the current one so feel free to ask me questions.

@JohannesHoppe
Copy link
Contributor Author

@filipesilva Ok, so we got Webpack now. But github-pages-deploy.ts is still based on ember-cli. Will this stay as it is, our should we prepare for webpack plugins?

@filipesilva
Copy link
Contributor

Oh wow, good catch! We didn't update github-pages-deploy.ts to use the new tasks. I'll put up a PR doing that.

It only really depends on the build task so the logic shouldn't be affected at all.

@filipesilva
Copy link
Contributor

I updated #1633 to also fix that, since I had to edit it in that PR as well.

@JohannesHoppe
Copy link
Contributor Author

I also reported this here: #1672
Going to close it, but will monitor that feature! ;-)

JohannesHoppe added a commit to angular-schule/angular-cli-ghpages that referenced this pull request Aug 18, 2016
…ate angular-cli.json) has landed

see angular/angular-cli#1070 (Update README.md - mentioning angular-cli-ghpages addon)
see angular/angular-cli#1672 ( `ng github-pages:deploy` still requires `angular-cli-build.js` )
@filipesilva
Copy link
Contributor

@JohannesHoppe now with beta.14 the webpack surface should be stable.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants